Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow menu bar visibility to be set in the settings #2759

Merged
merged 1 commit into from
Jan 7, 2019
Merged

allow menu bar visibility to be set in the settings #2759

merged 1 commit into from
Jan 7, 2019

Conversation

richardtks
Copy link
Contributor

Description

  • Allow menu bar visibility to be set in the preferences.
  • Allow the shortcut key to toggle menu bar visibility to be set in the hotkey.

Issue fixed

#2707

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Screenshot:

  • Show menu bar option
    togglemenubar

  • Toggle menu bar visibility hotkey
    image

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Dec 28, 2018
ZeroX-DG
ZeroX-DG approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 6, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 6, 2019

Works fine on Linux but I haven't tested it on window or mac. @richardtks which os you used to test this?

@richardtks
Copy link
Contributor Author

@ZeroX-DG, I am using linux OS as well.

@Rokt33r Rokt33r added awaiting review ❇️ Pull request is awaiting a review. and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 7, 2019
Rokt33r
Rokt33r requested changes Jan 7, 2019
View reviewed changes
Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think menu bar should be shown by default. This looks a break change for me.

@richardtks
Copy link
Contributor Author

@Rokt33r, if I am not mistaken, menu bar is invisible by default in linux os while menu bar in window is visible by default. Are you fine that menu bar should be visible by default across all the os?

@Rokt33r
Copy link
Member

Rokt33r commented Jan 7, 2019 •
edited
Loading

default in linux os

Could you tell me specific desktop env? Each desktop env has different behavior.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 7, 2019

@Rokt33r I think he's talking about this line of code:
https://github.com/BoostIO/Boostnote/blob/0289caad670fd8c3a8f8e1cac09fb1ca5c2e91fd/lib/main-window.js#L9
With the current code, the menu only show for Windows OS and it will be hidden on other OS unless the user press Alt.
https://github.com/BoostIO/Boostnote/blob/0289caad670fd8c3a8f8e1cac09fb1ca5c2e91fd/lib/main-window.js#L25

@Rokt33r
Copy link
Member

Rokt33r commented Jan 7, 2019

Seems like I was confused by my old dirty code. LGTM now.

@Rokt33r Rokt33r merged commit 5a9de1a into BoostIO:master Jan 7, 2019
@Rokt33r Rokt33r added next release (v0.11.13) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 7, 2019
@Rokt33r Rokt33r mentioned this pull request Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardtks @ZeroX-DG @Rokt33r